Skip to content

πŸ”’ fix(scan): prevent silent event drop on context cancellation - #162

Open
mendsec wants to merge 1 commit into
developfrom
fix-scanstream-event-drop-15801659817991662677
Open

mendsec wants to merge 1 commit into
developfrom
fix-scanstream-event-drop-15801659817991662677

Conversation

@mendsec

@mendsec mendsec commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

What

Implemented a two-stage select pattern inside ScanStream's onEvent callback in pkg/scan/scan.go.

Risk

When sending critical terminal events (such as EventLifecycleComplete) to eventChan while ctx.Done() is simultaneously ready, Go's pseudo-random select could silently choose to abort without sending the event. This causes consumer frontends to hang indefinitely waiting for the scan completion event.

Solution

Added a first-pass non-blocking select prioritizing the eventChan send over context cancellation checking. The fallback default block then enters the standard blocking select encompassing both the channel and ctx.Done(). This guarantees the terminal event gets enqueued successfully if the channel has capacity.


PR created automatically by Jules for task 15801659817991662677 started by @mendsec

Co-authored-by: mendsec <12684528+mendsec@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Up to standards βœ…

🟒 Issues 0 issues

Results:
0 new issues

View in Codacy

🟒 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@github-actions
github-actions Bot deleted the fix-scanstream-event-drop-15801659817991662677 branch October 25, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant