Skip to content

πŸ”’ Fix goroutine leaks on context cancellation in scan workers - #161

Open
mendsec wants to merge 1 commit into
developfrom
fix-goroutine-leak-context-cancellation-3287756229580356083
Open

mendsec wants to merge 1 commit into
developfrom
fix-goroutine-leak-context-cancellation-3287756229580356083

Conversation

@mendsec

@mendsec mendsec commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator
  • What: Fixed goroutine leaks in pkg/engine (async dispatcher) and pkg/ports (TCP scanner) that occurred when the context was prematurely cancelled.
  • Risk: Goroutine and socket leaks on long-running processes when scans are repeatedly cancelled by the user.
  • Solution: Implemented the two-stage select pattern for critical events in asyncDispatcher and wrapped channel sends in ScanPorts with a ctx.Done() select.

PR created automatically by Jules for task 3287756229580356083 started by @mendsec

Implemented two-stage select pattern for asyncDispatcher to prevent
deadlocks on critical event emission when the scan context is cancelled.
Also wrapped channel sends in ScanPorts with context cancellation
select to ensure worker routines don't block indefinitely.

Co-authored-by: mendsec <12684528+mendsec@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Up to standards βœ…

🟒 Issues 0 issues

Results:
0 new issues

View in Codacy

🟒 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@github-actions
github-actions Bot deleted the fix-goroutine-leak-context-cancellation-3287756229580356083 branch October 25, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant