[FIX] Apply Ruff fix to chainladder/adjustments. - #1299
Open
genedan wants to merge 1 commit into
Open
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gd_ruff_fix_workflow #1299 +/- ##
========================================================
- Coverage 91.66% 91.65% -0.01%
========================================================
Files 93 93
Lines 5437 5431 -6
Branches 704 704
========================================================
- Hits 4984 4978 -6
Misses 328 328
Partials 125 125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
henrydingliu
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Stacked PR on top of #1290. Fixes files in
chainladder/adjustments.I commented out some lines per #1298. Also added an exception for the disposal rate array to keep it in triangle format (rather than one element per line).
Related GitHub Issue(s)
#1216
Additional Context for Reviewers
Checklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Low Risk
Mostly lint and formatting; the bootstrap exception narrowing and commented DOF block are small behavioral/documentation tweaks in bootstrap simulation code.
Overview
Brings
chainladder/adjustments(and related tests) in line with the project Ruff rules and drops the per-file Ruff ignores for those paths inpyproject.toml.In
BootstrapODPSample, hat-matrix failure handling now catchesnp.linalg.LinAlgErrorinstead of a bareexcept, and the unused degree-of-freedom adjustment block at the end offitis commented out (per #1298). The rest of the module changes are formatting and small style fixes (e.g.is notfor type checks).disposal.pyand the adjustment tests are mostly quote/format/docstring cleanup;test_disposalkeeps the Friedland expected array in triangular layout via# fmt: offand explicit float literals so Ruff does not flatten the assertion data.trend.pydrops an unusedpandasimport.Reviewed by Cursor Bugbot for commit 491ec61. Bugbot is set up for automated code reviews on this repo. Configure here.