[FIX] Apply Ruff fix to chainladder/tails. - #1296
Open
genedan wants to merge 1 commit into
Open
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gd_ruff_fix_methods #1296 +/- ##
=======================================================
- Coverage 91.66% 91.66% -0.01%
=======================================================
Files 93 93
Lines 5437 5436 -1
Branches 704 704
=======================================================
- Hits 4984 4983 -1
Misses 328 328
Partials 125 125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
henrydingliu
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Stacked PR on #1290. Fixes
chainladder/tailsfiles.Related GitHub Issue(s)
#1216
Additional Context for Reviewers
Checklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Low Risk
Formatting and lint-only edits to tail reserving code; no intended algorithm or API changes beyond equivalent type checks.
Overview
Applies Ruff lint and format cleanup across
chainladder/tails/base.py,bondy.py, andcurve.pyso those modules meet the project rules without per-file ignores.Changes are mostly mechanical: docstring/layout formatting, spacing around operators and dict literals, double-quoted strings, and wrapping long lines.
TailBondydrops an unusedDevelopmentBaseimport;TailCurveremoves an unusednum_to_nanimport and replacestype(...) == slicewithtype(...) is slicefor the deprecatedfit_periodslice path.pyproject.tomlremoves the Ruffper-file-ignoresentries for the three tail files now that they pass the selected rules.Reviewed by Cursor Bugbot for commit e9a0dd8. Bugbot is set up for automated code reviews on this repo. Configure here.