[FIX] Apply Ruff fix to chainladder/methods. - #1295
Open
genedan wants to merge 2 commits into
Open
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gd_ruff_fix_development #1295 +/- ##
===========================================================
- Coverage 91.67% 91.66% -0.01%
===========================================================
Files 93 93
Lines 5440 5437 -3
Branches 704 704
===========================================================
- Hits 4987 4984 -3
Misses 328 328
Partials 125 125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Stacked pull request on #1290. Fixes
chainladder/methodsfiles.Related GitHub Issue(s)
#1216
Additional Context for Reviewers
Checklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Low Risk
Cosmetic and lint-only changes; reserve method behavior should be unchanged aside from docstring rendering in
MackChainladder.Overview
Brings
chainladder/methods(and its tests) in line with the project Ruff rules as part of the #1216 cleanup stack on #1290. There is no intended change to reserving logic—only style and lint hygiene.Library code: Drops unused
numpyimports frombase.py,capecod.py, and top-levelmack.py; normalizes quotes, spacing, docstrings, and line breaks (includingMackChainladder’s class docstring layout and**2operator formatting).MethodBase.validate_Xkeeps the sklearn-style name with an explicit# noqa: N802.Tests: Same mechanical formatting in
test_benktander,test_capecod,test_mack, andtest_predict.Config: Removes the per-file Ruff
per-file-ignoresentries for those methods modules now that they pass without exemptions.Reviewed by Cursor Bugbot for commit 198832c. Bugbot is set up for automated code reviews on this repo. Configure here.