[FIX] Apply Ruff fix to chainladder/development. - #1294
Open
genedan wants to merge 2 commits into
Open
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## gd_ruff_fix_plots #1294 +/- ##
=====================================================
- Coverage 91.69% 91.69% -0.01%
=====================================================
Files 96 96
Lines 5456 5453 -3
Branches 702 702
=====================================================
- Hits 5003 5000 -3
Misses 328 328
Partials 125 125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
henrydingliu
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Stacked pull request on #1290. Ruff cleanup of
chainladder/developmentfiles.Related GitHub Issue(s)
#1216
Additional Context for Reviewers
Checklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Low Risk
Lint and formatting only in development estimators and tests; Munich renames are private methods with no reserving logic changes.
Overview
This PR Ruff-cleans the
chainladder/developmentpackage and its unit tests so those modules meet the repo lint rules without per-file ignores.Production code changes are almost entirely formatting and style: wrapped signatures, normalized quotes/spacing, docstring tweaks, removed unused imports (
numpyinglm.py, unusedDevelopment/pandasinincremental.py, unused sklearn preprocessors inlearning.py), and small idiomatic fixes such asnot X.is_cumulativeandweighted_step is NoneinDevelopmentML. Clark growth helpers_G/G_keep their names with# noqa: N802; Munich private helpers are renamed_get_MCL_*→_get_mcl_*with call sites updated—no public API change.Tests are reformatted similarly, with minor lint fixes (e.g. bare
except→except Exception, pytest B018 assignments to_, dropping an unusedxerrorvariable).pyproject.tomldrops the Ruffper-file-ignoresentries for the cleaned development modules and tests, so those paths are now held to the full rule set.Reviewed by Cursor Bugbot for commit c55a03a. Bugbot is set up for automated code reviews on this repo. Configure here.