Skip to content

Ruff hot fix - #1279

Merged
genedan merged 1 commit into
mainfrom
ruff-hot-fix
Sep 4, 2026
Merged

Ruff hot fix#1279
genedan merged 1 commit into
mainfrom
ruff-hot-fix

Conversation

@henrydingliu

@henrydingliu henrydingliu commented Sep 4, 2026

Copy link
Copy Markdown
Member

there was an extra ruff ignore for friedland chapter 7

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

Checklist

  • I passed tests locally for both code (uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)

Note

Low Risk
Single-line Ruff configuration cleanup with no runtime or application logic impact.

Overview
Removes a duplicate [tool.ruff.lint.per-file-ignores] entry for docs/friedland/chapter_7_part_2.ipynb that only ignored E241. The notebook is still covered by the remaining rule list (N802); this is config cleanup, not a change to which violations Ruff enforces for that file beyond dropping the redundant line.

Reviewed by Cursor Bugbot for commit cdcfed2. Bugbot is set up for automated code reviews on this repo. Configure here.

there was an extra ruff ignore for friedland chapter 7
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 15.4% of exported symbols fully typed (213 / 1381)

Known Ambiguous Unknown Total
Project (head) 213 111 1057 1381

Other symbols referenced but not exported by chainladder: 13

Known Ambiguous Unknown Total
Other (head) 3 1 9 13

Symbols without documentation:

  • Functions without docstring: 325
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.68%. Comparing base (5b79e32) to head (cdcfed2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1279   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          93       93           
  Lines        5447     5447           
  Branches      704      704           
=======================================
  Hits         4994     4994           
  Misses        328      328           
  Partials      125      125           
Flag Coverage Δ
unittests 91.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@genedan
genedan merged commit 670e86a into main Sep 4, 2026
24 checks passed
@genedan
genedan deleted the ruff-hot-fix branch September 4, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants