Chapter 11 - #1272
Merged
Merged
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chapter_11_parking #1272 +/- ##
===================================================
Coverage 91.75% 91.75%
===================================================
Files 93 93
Lines 5447 5447
Branches 702 702
===================================================
Hits 4998 4998
- Misses 326 330 +4
+ Partials 123 119 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
Checklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Low Risk
Documentation and style-only test formatting with no production code or behavioral changes.
Overview
Applies formatting-only updates to the Friedland Chapter 11 frequency–severity notebook and a tiny test cleanup—no change to actuarial logic or library behavior.
In
docs/friedland/chapter_11.ipynb, cells are reformatted for consistency: double-quoted strings, spacing around operators, wrappedcl.model_diagnosticsandformat_exhchains, and a one-character fix in a comment about the Exhibit III tail factor. Exhibit assertions and calculations are unchanged.In
chainladder/utils/tests/test_utilities.py,test_model_diagnostics_groupbyonly adds spaces after commas innp.allclose(..., atol=atol, ...).Reviewed by Cursor Bugbot for commit 8efe214. Bugbot is set up for automated code reviews on this repo. Configure here.