Skip to content

Chapter 11 - #1271

Merged
henrydingliu merged 3 commits into
casact:chapter_11_parkingfrom
henrydingliu:chapter_11
Sep 2, 2026
Merged

Chapter 11#1271
henrydingliu merged 3 commits into
casact:chapter_11_parkingfrom
henrydingliu:chapter_11

Conversation

@henrydingliu

@henrydingliu henrydingliu commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

Checklist

  • I passed tests locally for both code (uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)

Note

Low Risk
Changes are documentation and formatting with no intentional behavior changes; residual risk is only if an unused import removal or notebook edit accidentally altered a calculation, which the existing exhibit asserts are meant to catch.

Overview
Adds and reformats the Friedland Chapter 11 documentation notebook (docs/friedland/chapter_11.ipynb), walking through frequency–severity exhibits with the same helper patterns used in other Friedland chapters. The notebook cells are largely style-only updates (Black/Ruff-friendly layout, double quotes, wrapped lines); exhibit logic and golden assert checks are preserved, with # ruff: noqa: E241 where aligned numeric literals are intentional.

Supporting changes are minor: TriangleWeight drops an unused sparse import and gets whitespace/type-hint formatting (including the existing full-triangle n_periods weight path, still covered by test_triangleweight_full_triangle). WeightedRegression and test_utilities.py pick up the same lint-driven tweaks (e.g. assert options.AUTO_SPARSE, rename llatest in a concat immutability test).

Reviewed by Cursor Bugbot for commit ea5c34e. Bugbot is set up for automated code reviews on this repo. Configure here.

@henrydingliu
henrydingliu marked this pull request as ready for review September 2, 2026 22:34
@henrydingliu
henrydingliu merged commit 9e98129 into casact:chapter_11_parking Sep 2, 2026
9 of 11 checks passed
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 15.1% of exported symbols fully typed (209 / 1380)

Known Ambiguous Unknown Total
Project (head) 209 112 1059 1380

Other symbols referenced but not exported by chainladder: 13

Known Ambiguous Unknown Total
Other (head) 3 1 9 13

Symbols without documentation:

  • Functions without docstring: 325
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.75%. Comparing base (efaec4c) to head (ea5c34e).
⚠️ Report is 8 commits behind head on chapter_11_parking.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           chapter_11_parking    #1271      +/-   ##
======================================================
- Coverage               91.75%   91.75%   -0.01%     
======================================================
  Files                      93       93              
  Lines                    5448     5447       -1     
  Branches                  702      702              
======================================================
- Hits                     4999     4998       -1     
  Misses                    326      326              
  Partials                  123      123              
Flag Coverage Δ
unittests 91.75% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant