Skip to content

ruff fix - #1269

Merged
henrydingliu merged 1 commit into
casact:chapter_11_parkingfrom
henrydingliu:chapter_11
Sep 2, 2026
Merged

ruff fix#1269
henrydingliu merged 1 commit into
casact:chapter_11_parkingfrom
henrydingliu:chapter_11

Conversation

@henrydingliu

@henrydingliu henrydingliu commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

Checklist

  • I passed tests locally for both code (uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)

Note

Low Risk
Formatting and import cleanup only; no logic or API changes.

Overview
Applies Ruff auto-fixes across a few files with no intended behavior changes.

In test_utilities.py, imports are consolidated (duplicate date_delta_adjustment removed), an unused get_array_module() call is dropped from test_triangle_json_io, and spacing is normalized around operators and keyword arguments in model-diagnostics tests. In _manifest.py, the friedland_xyz_auto_bi columns list is reformatted to one entry per line. In base.py, a comment is adjusted to # w_ after #.

Reviewed by Cursor Bugbot for commit 51ad443. Bugbot is set up for automated code reviews on this repo. Configure here.

@henrydingliu
henrydingliu marked this pull request as ready for review September 2, 2026 22:06
@henrydingliu
henrydingliu merged commit efaec4c into casact:chapter_11_parking Sep 2, 2026
9 of 11 checks passed
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 15.0% of exported symbols fully typed (196 / 1308)

Known Ambiguous Unknown Total
Project (head) 196 111 1001 1308

Other symbols referenced but not exported by chainladder: 13

Known Ambiguous Unknown Total
Other (head) 3 1 9 13

Symbols without documentation:

  • Functions without docstring: 315
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.75%. Comparing base (dd18092) to head (51ad443).
⚠️ Report is 506 commits behind head on chapter_11_parking.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           chapter_11_parking    #1269      +/-   ##
======================================================
+ Coverage               91.20%   91.75%   +0.55%     
======================================================
  Files                      91       93       +2     
  Lines                    5380     5448      +68     
  Branches                  683      702      +19     
======================================================
+ Hits                     4907     4999      +92     
+ Misses                    343      326      -17     
+ Partials                  130      123       -7     
Flag Coverage Δ
unittests 91.75% <ø> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant