Repository navigation
feat: index public-realm deploys and system reindexes without realm events #6914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d09826f
Index public-realm deploys and system reindexes without realm events
habdelra 14fb6fa
Merge remote-tracking branch 'origin/cs-14188-a-bulk-_atomic-write-br…
habdelra 5525720
Address review of silent system indexing
habdelra 781e37a
Merge remote-tracking branch 'origin/cs-14188-a-bulk-_atomic-write-br…
habdelra 525ddf6
Document boxel file write --no-realm-events in the file-ops skill
habdelra 1bc0a02
Merge remote-tracking branch 'origin/cs-14188-a-bulk-_atomic-write-br…
habdelra 064db81
Merge remote-tracking branch 'origin/main' into cs-14191-silent-publi…
habdelra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Claude Code 🤖] This test can't see the two broadcasts a silent from-scratch pass is supposed to withhold. The worker sends
prerender_htmland the follow-upincrementalevent throughreportRealmEvent. The test worker thattests/helpers/index.tsbuilds (new Worker({...})) has noreportRealmEvent, so those events are dropped whatever the args say. The only gate the test pins isstartReindex's ownfull/invalidation broadcast. If you revertannounce: fromScratchAnnounces(args)or thefollowUpIncrementalArgs(…, fromScratchAnnounces(args))change intasks/indexer.ts, this test stays green. That follows from how the worker is built; I haven't run it, because the test lane is shared.The cheapest way to pin the render job: once the silent reindex settles, read the
prerender_htmlrow it spawned for this realm fromjobsand assertargs.announce === false, then asserttruefor the write without the header.full-reindex-testreadsrealmEventsoff a job row the same way. For the follow-up args you need a commit-validation scenario with a worker that records events, andindex-commit-validation-test.tsalready builds one. The description's test plan says this test covers "noprerender_htmlevent"; please correct that too.Coverage gap in this PR. Non-blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Claude Code 🤖] Right, the test worker has no
reportRealmEvent. Fixed in 5525720. The test now reads the jobs the silent write spawned and asserts that thefrom-scratch-indexjob carriesrealmEvents: falseand every spawnedprerender_htmljob carriesannounce: false. Those are what the worker's broadcasts read. I'll correct the description's test plan too.