-
Notifications
You must be signed in to change notification settings - Fork 68
Turret child object #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Ikreb1
wants to merge
14
commits into
main
Choose a base branch
from
turret-child-object
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
64a8574
first iteration of filling in evechildturret and fix some typoes in e…
Ikreb1 3565268
fix formatting
Ikreb1 add33a3
initalize turret variable and setup _blue file and fix compile error
Ikreb1 2462b9a
add validation guards
Ikreb1 f82b14d
fix async loading
Ikreb1 e58b0bf
cleanup more todos
Ikreb1 34784fe
impact behviour support
Ikreb1 0cbdbfd
resolve more todos
Ikreb1 e05dd34
Add posemodifer interface and remove more todos
Ikreb1 b22b565
more animation setup, play/stop working now
Ikreb1 e338a31
runtime child init and firingEffectResPath consumption
Ikreb1 3b3bd27
remove animation clearing fix
Ikreb1 889e172
revert initalization and stopanimation
Ikreb1 170bddd
workaround because clang formatter is being weird
Ikreb1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been spun out into their own PR and ill be merging it in and this should get removed once you updated latest on main when that other PR is in