Conversation
Replace the manual time.time patch (a hardcoded 17-element float array with .pop()) with the shared test_utils.mock_timeit() context manager. Two other tests in the same file already use mock_timeit(). Remove the now-unused unittest.mock.patch import. Fixes capitalone#806
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the manual
time.timepatch (a hardcoded 17-element float array with.pop()) with the sharedtest_utils.mock_timeit()context manager. Two other tests in the same file (lines 934, 998) already usemock_timeit(). Remove the now-unusedfrom unittest.mock import patchimport.Changes
test_categorical_column_profile.py— +1, -3Fixes #806
Previously submitted as #1219 (closed) and #1223 (targeted stale
devbranch). Clean resubmission againstmain.