Skip to content

Permission error message not localised for non-English locales#549

Open
PujaDeshmukh17 wants to merge 6 commits into
developfrom
RBSDMS-MessageErrorFix-Feature
Open

Permission error message not localised for non-English locales#549
PujaDeshmukh17 wants to merge 6 commits into
developfrom
RBSDMS-MessageErrorFix-Feature

Conversation

@PujaDeshmukh17

@PujaDeshmukh17 PujaDeshmukh17 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

Problem:
When a user without upload permissions attempted to attach a file, the error popup always displayed in English regardless of the user's locale:

"You do not have the required permissions to upload attachments. Please contact your administrator for access."

Root Cause:

Hardcoded call site in SDMServiceImpl.java
One specific throw site in the getObject method (403 response branch) used the raw Java constant SDMConstants.USER_NOT_AUTHORISED_ERROR directly, bypassing the SDMUtils.getErrorMessage() lookup that all other throw sites use.

Any documentation

image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I follow Java Development Guidelines for SAP
  • I have tested the functionality on my cloud environment.
  • I have provided sufficient automated/ unit tests for the code.
  • I have increased or maintained the test coverage.
  • I have ran integration tests on my cloud environment.
  • I have validated blackduck portal for any vulnerability after my commit.

Upload Screenshots/lists of the scenarios tested

  • I have Uploaded Screenshots or added lists of the scenarios tested in description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant