Repository navigation
feat(website): serve the site at nostream.dev and redirect every other host to it #889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
367907f
feat(website): serve the site at nostream.dev and redirect every othe…
chappie-daemon 85c4ec0
fix(website): run the worker before assets, and keep previews off the…
chappie-daemon 1c86cac
fix(website): no redirect loop with no canonical host, and compare th…
chappie-daemon 3860762
fix(website): serve previews on the preview host instead of bouncing …
chappie-daemon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| --- | ||
| 'nostream-website': patch | ||
| --- | ||
|
|
||
| The site now lives at **https://nostream.dev**, and every other host redirects to it over https. | ||
|
|
||
| The router worker answers on `nostream.dev` and `www.nostream.dev` as well as the preview | ||
| domain, and `CANONICAL_HOST` decides which one serves content: any other host the routes | ||
| catch — `www`, or `ema.tnsor.network` for a non-preview path — gets a `301` to the canonical | ||
| host, and `http` gets a `301` to the same URL over `https`. One origin serving means one | ||
| canonical URL, so `www` and the apex cannot split search ranking by both answering `200`. | ||
|
|
||
| Previews deliberately stay on `ema.tnsor.network/preview/<n>/`: that is why the domain | ||
| remains bound. A preview build must never sit on the production domain, and a preview's own | ||
| `SITE_URL` stays the preview origin so its absolute links and canonical tags cannot claim | ||
| `nostream.dev`. | ||
|
|
||
| The domain is an input now, not a constant: `SITE_URL` for the build, `CANONICAL_HOST` for | ||
| the worker, both set in `deploy-website.yml`. Moving again is two lines rather than a search | ||
| through the source, the social card and the README. | ||
|
|
||
| **Cloudflare-side setup this needs before it takes effect**: the `nostream.dev` zone must | ||
| exist, and both `nostream.dev` and `www.nostream.dev` resolve through the worker's | ||
| declared custom domains on the next deploy. Turning on the zone's *Always Use HTTPS* | ||
| setting makes the upgrade happen at the edge, before the worker; the worker's own `301` | ||
| covers the case where that setting is off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.