Repository navigation
Conversation
6 failing -> 0 failing. Doctor reads optional-module findings from a port the daemon fills with the agent-device supervisor's availability; the CLI prints one stderr line per finding; protocol 30 -> 31.
1 failing -> 0 failing.
Contributor
Author
Review notesNot blocking, not verified. Each is one reviewer's claim.
Written by an agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #471
Status
Implement: done (17/17 green) Review: round 1 + claims-only passed Hardware: n/a Gate: running
Next: gate
Done when
isDrift's exclusions makes thedoctor.reconciledtest fail (run: "leaves the finding out of doctor.reconciled's driftFindings and emits no other event for it" fails).Assumptions
agent-device-unavailablefinding type,OptionalModuleFinding, theoptionalModulesoption) and anagentDeviceFindingsstub returning no findings — the pre-commit typecheck needs them, and the stub makes its test fail on an assertion rather than a missing module. No behaviour is built.{ error: errorMessage(error) }, not the raw{ error }— anErrorserializes to{}, so the message is the conservative way to name it.PROTOCOL_VERSION_RANGE) with the pins indaemon-protocol,daemon/serverandgateway/servicetests moved — the spec says "protocol +1 at merge".Review
Spec review: 1 blocking, 0 fixed, 0 notes. Code review: 2 blocking, 2 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 1 notes.
Rounds: 1. Tokens: 12.0M.
Rejected:
Fixed unreviewed: claims: docs/CLI.md:2141 restart applies to every cause except a failed start, which retries every 30 s.
Written by an agent.