Repository navigation
Conversation
#469) Waits for them up to lease.endWaitMs; nuke, settle and dispose cut the wait short. 40 failing -> 0 failing
0 failing -> 0 failing
0 failing -> 0 failing
Contributor
Author
Review notesNot blocking, not verified. Each is one reviewer's claim.
Written by an agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #469
Status
Implement: done (43/43 green) Review: round 2 + claims-only passed Hardware: n/a Gate: running
Next: gate
Done when
reclaim.reclaimmakes "the driver's reclaim does not start until the participant returns" fail.beginMaintenancemakes the firstnuketest fail.src/leasing/create-leasing.test.tsandsrc/leasing/lease-release-coordinator.test.tsadds only the new config key and the coordinator's new options; the participant tests are all insrc/leasing/lease-end-participants.test.ts.Assumptions
LeasingOptions.leaseEndParticipants,TestEngineOptions.leaseEndParticipants,Config.lease.endWaitMswith its 600000 default) is type-only, so the tests and the commit hook's typecheck compile; no behaviour yet.leaseId,deviceIdanderror, as the coordinator's existing background-reclaim error uses.leaseEndoption (clock, ceiling, participants), set only when a participant is registered — it keeps the no-participant path and the existing coordinator tests unchanged.lease.endWaitMsis any positive number up to 2147483647 (not only integers) — the spec says "positive number".Review
Spec review: 1 blocking, 1 fixed, 1 notes. Code review: 2 blocking, 1 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 2. Tokens: 4.2M.
Rejected:
Written by an agent.