Skip to content

android: patch RN settings.gradle.kts /tmp projectDir for Windows #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kraenhansen wants to merge 1 commit into
base: kh/adopt-static-h-node-api
Choose a base branch
from
+45 −19
Open

android: patch RN settings.gradle.kts /tmp projectDir for Windows #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions patches/react-native@0.87.0-nightly-20260529-88857d22f.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
diff --git a/settings.gradle.kts b/settings.gradle.kts
index 2036e0f16450b837223aad4b73cd1d556089d16d..a769520babe1423bb08399e5a932db50de7bad51 100644
--- a/settings.gradle.kts
+++ b/settings.gradle.kts
@@ -35,6 +35,11 @@ project(":packages:react-native:ReactAndroid:hermes-engine").projectDir =
// for :packages and :packages:react-native as well as otherwise the build from
// source will fail with a missing folder exception.

-project(":packages").projectDir = file("/tmp")
-
-project(":packages:react-native").projectDir = file("/tmp")
+// Patched by react-native-node-api: upstream hardcodes file("/tmp"), which does
+// not exist on Windows (there `/tmp` resolves to a non-existent <rootDir>/tmp),
+// so the build-from-source settings fail to configure. Use the JVM temp dir,
+// which exists on every platform (`/tmp` on posix, %TEMP% on Windows). Remove
+// this patch once React Native stops hardcoding "/tmp" here.
+project(":packages").projectDir = file(System.getProperty("java.io.tmpdir", "/tmp"))
+
+project(":packages:react-native").projectDir = file(System.getProperty("java.io.tmpdir", "/tmp"))
43 changes: 24 additions & 19 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ packages:
# platform binary; allow just that one rather than disabling the safety globally.
onlyBuiltDependencies:
- esbuild
patchedDependencies:
react-native@0.87.0-nightly-20260529-88857d22f: patches/react-native@0.87.0-nightly-20260529-88857d22f.patch
Loading