Repository navigation
feat(evals): add legend-state evals to async-state - #386
Open
mikolajadamowicz wants to merge 2 commits into
Open
mikolajadamowicz wants to merge 2 commits into
mikolajadamowicz wants to merge 2 commits into
Conversation
- Adds observable async lifecycle, computed/batch, persist/hydration, and two-way binding evals covering @legendapp/state v3 patterns - Updates async-state README, whitepaper eval counts, and adds the @legendapp/state dependency feat(evals): add 4 legend-state evals to async-state - Adds observable async lifecycle, computed/batch, persist/hydration, and two-way binding evals covering @legendapp/state v3 patterns - Updates async-state README, whitepaper eval counts, and adds the @legendapp/state dependency
- Adds a new eval (lazy-loaded product screen) covering async observable data fetching with syncState-derived loading/error status, plus requirements.yaml grading it. - Updates existing Legend State evals' prompts to specify v3 and removes unused React default imports flagged by the linter. - Bumps eval counts (138→139, async-state 17→18) in README and the benchmark methodology paper to stay in sync.
artus9033
self-requested a review
August 19, 2026 11:09
artus9033
approved these changes
Aug 20, 2026
artus9033
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Legend State (
@legendapp/statev3) as a new baseline library in theasync-statecategory, with 5 focused evals covering its fine-grained observable model. Each eval ships a prompt, atomic requirements, a baselineapp/App.tsx, and a reference implementation.async-stategrows from 13 → 18 evals; the suite total goes from 134 → 139.Evals Added
rn-legend-state-observable-async-action-lifecycleobservablestore, explicit idle/loading/success/error action lifecycle, tracked reads viauseValue/use$/observerrn-legend-state-computed-derived-state-batchbatchfor multi-field writes,Memo/Computedfine-grained renderingrn-legend-state-persist-asyncstorage-hydration-gatesyncObservable+ AsyncStorage persist plugin, hydration gating onsyncState(...).isPersistLoadedrn-legend-state-reactive-two-way-input$TextInputtwo-way binding via$value, computed dirty flag,Show-driven save barrn-legend-state-async-observable-lazy-loadsyncStateinstead ofuseEffect+useStateCategory Documentation
evals/async-state/README.mdgains a Legend State baseline entry, v3 doc references (including the v2 → v3 migration notes forpersistObservable→syncObservableanduseSelector→useValue), and six new traceability rules:D19— read observables through tracked contexts, not untracked.get()in renderD20— model derived values as computed functions in the observableD21— batch multi-field writes to avoid intermediate renders and persistence churnD22— gate persisted UI onisPersistLoadedD23— two-way bind inputs with reactive$components instead of `useStateD24— model lazily-loaded server data as async observables withsyncStatePolicies Enforced
batch,Memo,syncState,isPersistLoaded,$value, etc. are requirement-side only where applicable)app/App.useState/useEffect` version the prompt asks to replacedummyjson.comendpoint patterns and documented response shapes; evals 16 and 18 are fully localOther Changes
testbench/package.json: adds@legendapp/state@^3.0.0-beta.48README.mdandpaper/benchmark-methodology-whitepaper.tex: updated eval counts and the async-state category scope to include Legend State