Repository navigation
feat(native): add registerEvent to the Swift SDK (#126) #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
V3RON
merged 9 commits into
issue-125-add-appduct-list-events-mcp-tool
from
issue-126-add-registerevent-to-the-swift-sdk
Oct 2, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
55ca715
test: add registerEvent to the Swift SDK (#126)
V3RON 22c6208
feat(ios): add registerEvent to the Swift SDK (#126)
V3RON 38452dd
Merge remote-tracking branch 'origin/issue-125-add-appduct-list-event…
V3RON 65338d2
fix(ios): send event registry frames through one ordered queue (#126)
V3RON 847d462
Merge remote-tracking branch 'origin/issue-125-add-appduct-list-event…
V3RON cad8cf3
Merge remote-tracking branch 'origin/issue-125-add-appduct-list-event…
V3RON b175395
Merge remote-tracking branch 'origin/issue-125-add-appduct-list-event…
V3RON e88d6a4
Merge remote-tracking branch 'origin/issue-125-add-appduct-list-event…
V3RON aab59f1
Merge remote-tracking branch 'origin/issue-125-add-appduct-list-event…
V3RON File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| [ | ||
| { | ||
| "name": "snapshot-lists-every-declared-event-in-declaration-order", | ||
| "sessionId": "XzAERP54_Goh74hZ", | ||
| "declaredBeforeAck": [ | ||
| { | ||
| "name": "checkout_completed", | ||
| "description": "Fired once an order finishes checkout.", | ||
| "payload_schema": { | ||
| "type": "object", | ||
| "properties": { | ||
| "orderId": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "orderId" | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "name": "cart.item_added", | ||
| "description": "An item went into the cart." | ||
| } | ||
| ], | ||
| "afterAck": [], | ||
| "frames": [ | ||
| { | ||
| "type": "event_registry_snapshot", | ||
| "session_id": "XzAERP54_Goh74hZ", | ||
| "events": [ | ||
| { | ||
| "name": "checkout_completed", | ||
| "description": "Fired once an order finishes checkout.", | ||
| "payload_schema": { | ||
| "type": "object", | ||
| "properties": { | ||
| "orderId": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "orderId" | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "name": "cart.item_added", | ||
| "description": "An item went into the cart." | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "name": "snapshot-with-no-declared-events-is-empty", | ||
| "sessionId": "XzAERP54_Goh74hZ", | ||
| "declaredBeforeAck": [], | ||
| "afterAck": [], | ||
| "frames": [ | ||
| { | ||
| "type": "event_registry_snapshot", | ||
| "session_id": "XzAERP54_Goh74hZ", | ||
| "events": [] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "name": "declaring-after-the-ack-sends-an-upsert-delta", | ||
| "sessionId": "XzAERP54_Goh74hZ", | ||
| "declaredBeforeAck": [], | ||
| "afterAck": [ | ||
| { | ||
| "op": "register", | ||
| "event": { | ||
| "name": "cart.item_added", | ||
| "description": "An item went into the cart." | ||
| } | ||
| } | ||
| ], | ||
| "frames": [ | ||
| { | ||
| "type": "event_registry_snapshot", | ||
| "session_id": "XzAERP54_Goh74hZ", | ||
| "events": [] | ||
| }, | ||
| { | ||
| "type": "event_registry_delta", | ||
| "session_id": "XzAERP54_Goh74hZ", | ||
| "operation": "upsert", | ||
| "event": { | ||
| "name": "cart.item_added", | ||
| "description": "An item went into the cart." | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "name": "disposing-sends-a-remove-delta", | ||
| "sessionId": "XzAERP54_Goh74hZ", | ||
| "declaredBeforeAck": [ | ||
| { | ||
| "name": "checkout_completed", | ||
| "description": "Fired once an order finishes checkout.", | ||
| "payload_schema": { | ||
| "type": "object", | ||
| "properties": { | ||
| "orderId": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "orderId" | ||
| ] | ||
| } | ||
| } | ||
| ], | ||
| "afterAck": [ | ||
| { | ||
| "op": "remove", | ||
| "name": "checkout_completed" | ||
| } | ||
| ], | ||
| "frames": [ | ||
| { | ||
| "type": "event_registry_snapshot", | ||
| "session_id": "XzAERP54_Goh74hZ", | ||
| "events": [ | ||
| { | ||
| "name": "checkout_completed", | ||
| "description": "Fired once an order finishes checkout.", | ||
| "payload_schema": { | ||
| "type": "object", | ||
| "properties": { | ||
| "orderId": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "orderId" | ||
| ] | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "type": "event_registry_delta", | ||
| "session_id": "XzAERP54_Goh74hZ", | ||
| "operation": "remove", | ||
| "name": "checkout_completed" | ||
| } | ||
| ] | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of the blocker on the test: "deliver a
session_ack..., then apply eachafterAckstep" gives no sync point. Yetframesrequires the snapshot to show exactlydeclaredBeforeAckand to come before every delta. A Kotlin harness written to this text will hit the same race. Name the sync point here (for example "once theevent_registry_snapshotframe has been sent"), or state that the SDK must order them.