@kondee/chip md3 - #5081
Draft
k0ndee wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Refactors
Chiptoward the v6/MD3 API and implementation direction.Chip-specific sizing, color, and typescale values into a dedicatedtokens.tsfile, following the pattern used by other recently modernized components (e.g.Badge).Animated.timingdriven scale/elevation on press) in favor of a static elevation derived from theelevatedanddisabledprops.getChipColorsinutils.ts, renamed fromhelpers.tsx) to better align with MD3 state and color roles, including a dedicated ripple color and an avatar selected-overlay color.hitSlop, and moves the close icon intoTouchableRipplefor consistent ripple/state-layer feedback.compactandshowSelectedOverlayprops, which are no longer part of the MD3-aligned API (the selected overlay is now handled automatically for avatars).modefromflattooutlined.The example app has been updated to match the new API (e.g. dropping now-removed
showSelectedOverlayusage) and to showcase MD3-oriented Chip states.Related issue
Closes #4931
Test plan