Repository navigation
fix(create-react-native-library): use latest Community CLI - #959
Draft
RezoanurRahman wants to merge 1 commit into
Draft
RezoanurRahman wants to merge 1 commit into
RezoanurRahman wants to merge 1 commit into
Conversation
Updated vanilla example generation to use `@react-native-community/cli@latest`. Added a behavioral regression test for the generated `npx` command. Lint and typecheck pass; the full suite passes 30/30 with an extended timeout. Closes callstack#958
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #958
Summary
Updated vanilla example generation to use
@react-native-community/cli@latest.Added a behavioral regression test for the generated
npxcommand.Lint and typecheck pass; the full suite passes 30/30 with an extended timeout.
Changed files
packages/create-react-native-library/src/exampleApp/generateExampleApp.tspackages/create-react-native-library/src/exampleApp/generateExampleApp.test.tsVerification
yarn install --immutablepassedyarn run testpassedyarn run lintpassedyarn run typecheckpassedCode was written with Codex, reviewed and guided by me.