CI rehearsal only (do not merge) - #17
Closed
michael-moffett wants to merge 20 commits into
Closed
michael-moffett wants to merge 20 commits into
michael-moffett wants to merge 20 commits into
Conversation
…matrix A Gradle stdin/stdout runner over the Kotlin SDK's protocol functions, plus `harness/protocol-runners/kotlin.json`, so the spawned-runner block drives Kotlin. No protocol-layer vector reaches Kotlin today. Milestone 1 of our harness proposal puts Kotlin in the divergence matrix.
…-run steps in the kotlin harness job, and asserted Kotlin divergences in the spawned-runner matrix
…cratch (--rerun-tasks); 5/5 MainTest cases pass, the vitest suite is still unrun
…l as a must-pass case (TS reference re-parses Kotlin's header) and lists receipt.format as a known unsupported divergence
…lDist test) and Main.kt gains its 3-line header comment
…ned-runner block, with Kotlin's SDK gaps asserted by exact response
…elds after whole-object serialization (Go omitempty), with its unit test asserting the omission
…d digest; an empty request now returns parse_error, with a MainTest case for it
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| val fields = Json.encodeToJsonElement(PaymentChallenge.serializer(), challenge).jsonObject | ||
| return JsonObject( | ||
| fields.filter { (name, value) -> name !in setOf("expires", "digest") || value != JsonPrimitive("") }.mapValues { (name, value) -> | ||
| if (name == "request" || name == "opaque") decodeJson(value.jsonPrimitive.content) else value |
There was a problem hiding this comment.
opaque value. The SDK parses it as a string, but this runner tries to base64url-decode and JSON-parse it, returning parse_error for a valid challenge. Only request should be decoded this way.
Suggested change
| if (name == "request" || name == "opaque") decodeJson(value.jsonPrimitive.content) else value | |
| if (name == "request") decodeJson(value.jsonPrimitive.content) else value |
| } | ||
|
|
||
| private fun parseChallenge(input: JsonElement): JsonObject { | ||
| val challenge = MppHeaders.parseWWWAuthenticate(input.jsonObject.getValue("header").jsonPrimitive.content) |
There was a problem hiding this comment.
id="", the SDK parser checks that the field exists but does not reject its empty value. This runner returns a successful parse, although the canonical vector requires parse_error, so it reports an invalid challenge as valid.
Suggested change
| val challenge = MppHeaders.parseWWWAuthenticate(input.jsonObject.getValue("header").jsonPrimitive.content) | |
| val challenge = MppHeaders.parseWWWAuthenticate(input.jsonObject.getValue("header").jsonPrimitive.content) | |
| require(challenge.id.isNotEmpty()) { "challenge id must not be empty" } |
…ed as a known divergence with its exact response; the opaque and vector-coverage findings are answered with the earlier rulings
…d credential.format case through the runner; the other seven SDKs keep their smoke cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork CI only. Do not merge.