Repository navigation
feat(host)!: remove the Node host and node-pty (#76 phase 4b) - #158
Merged
Merged
Conversation
The Rust host is the only pty host now. - removed src/host/index.ts, the host.js build entry, settings.nodeHost (Settings → Advanced "Use the Node host") and node-pty with its rebuild (postinstall, trustedDependencies, asarUnpack; npmRebuild off): bun install builds no native module - host-start: hostBinary() finds wraithgrid-host for the app and for `wraithgrid host-stdio`; without it terminal panes can't start, so `bun run dev` and test:e2e build it first - the Node host's server, screen and pty manager moved to tests/support/node-host/ as the in-process host of the pane-host, router and CLI unit tests (fake ptys, a local pty interface) - parity suite: the Rust host only, headless xterm as the reference for resizes; test:host no longer builds the Electron app - Linux package checks run `wraithgrid-host --version`; README build requirements are Rust and a C linker; ADR 0001/0004, CONTEXT updated BREAKING CHANGE: settings.nodeHost is gone; a build without the Rust host binary can't run terminal panes. Closes #76 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4b of #76, the last one: the Rust host is the only pty host on Linux, macOS and Windows.
Removed
src/host/index.tsand thehost.jsbuild entry.settings.nodeHostand its Settings → Advanced row ("Use the Node host");WRAITHGRID_NODE_HOST.node-ptyand its rebuild:postinstall: electron-builder install-app-deps,trustedDependencies,asarUnpack,npmRebuild(now false).bun installbuilds no native module (it removed 3 packages here).python3is dropped from the Docker build image.Changed
host-start.tshostBinary()findswraithgrid-hostfor both the app andwraithgrid host-stdio: inresources/when packaged,host-rs/target/releasein development. New unit test covers both layouts.bun run devandbun run test:e2erun cargo first.SpawnRequest/SpawnResulttypes moved intosrc/host/protocol.ts.Tests
tests/support/node-host/. They are test-only, the in-process host that the pane-host, router and CLI unit tests (58) talk to, always with fake ptys; a small local interface replaces node-pty's types.pty-manager.test.ts(it tested the Node host's own pty code) is gone. Logged indocs/DECISIONS.md.wraithgrid-host --versioninstead of opening a node-pty pty.Docs: README build requirements are now Rust plus a C linker; ADR 0001 notes the host is the Rust binary; ADR 0004 says all phases are done; CONTEXT updated.
Still open after this (not in #76's phases): the Rust host has not run on a real Windows machine, a real Mac or arm64; the binary is not signed.
Closes #76
🤖 Generated with Claude Code