Repository navigation
feat(host): the Rust host on macOS (#76 phase 3a) - #153
Merged
Merged
Conversation
- scripts/build-mac-host.sh builds aarch64 and x86_64 and lipos one universal wraithgrid-host into host-rs/target/release, where electron-builder takes it for both the arm64 and the x64 app (ad-hoc signed with them); `bun run dist:mac` runs it first - the app looks for the binary on darwin too; Settings → Advanced "Use the Rust host" shows on macOS - CI: the macOS build job runs cargo test and the host parity suite Windows is phase 3b: portable-pty always quotes arguments, so the ready cmd.exe line of an npm .cmd CLI needs a ConPTY spawn of our own. Refs #76 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ease Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3a of #76: the Rust pty host on macOS. Windows follows as 3b.
scripts/build-mac-host.shbuildsaarch64-apple-darwinandx86_64-apple-darwinand lipos one universalwraithgrid-hostintohost-rs/target/release/. electron-builder bundles it in both the arm64 and the x64 app (mac.extraResources), ad-hoc signed with them;bun run dist:macruns the script first.cargo testandbun run test:host(the parity suite against the Node host), as therust-hostjob does on Linux. This is the first time the Rust host builds and runs on macOS: no code changes were needed to compile there, so this CI run is the check.Why Windows is separate: portable-pty always quotes each argument on Windows, so the ready
cmd.exe /d /s /c "…"line thatplatform.tsbuilds for npm.cmdCLIs (claude on Windows) can't pass through it. Windows needs a ConPTY spawn of our own with a raw command line, plus the named pipe, taskkill tree kill and Ctrl-C handling. Logged indocs/DECISIONS.md.Not done: never run on a real Mac (only CI's parity suite); signing/notarization needs a Developer ID (the app is ad-hoc signed today, unchanged). The universal build script runs only in
dist:mac(releases), not on every PR.Refs #76
🤖 Generated with Claude Code