chore: retire stale licensing guard exclusions - #931
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
blove
added a commit
that referenced
this pull request
Sep 1, 2026
Reviewed 2026-09-01. States the residual gap plainly — a Vercel-environment- specific failure is not caught pre-merge, only post-merge by `Deploy → Vercel` — and why requiring the status back was rejected: the consolidated `Vercel` context now covers every project, so it would let an unrelated project block a pure-website PR, reversing the #931 behaviour. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blove
added a commit
that referenced
this pull request
Sep 1, 2026
Reviewed 2026-09-01. States the residual gap plainly — a Vercel-environment- specific failure is not caught pre-merge, only post-merge by `Deploy → Vercel` — and why requiring the status back was rejected: the consolidated `Vercel` context now covers every project, so it would let an unrelated project block a pure-website PR, reversing the #931 behaviour. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blove
added a commit
that referenced
this pull request
Sep 1, 2026
Reviewed 2026-09-01. States the residual gap plainly — a Vercel-environment- specific failure is not caught pre-merge, only post-merge by `Deploy → Vercel` — and why requiring the status back was rejected: the consolidated `Vercel` context now covers every project, so it would let an unrelated project block a pure-website PR, reversing the #931 behaviour. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blove
added a commit
that referenced
this pull request
Sep 1, 2026
…eck trap (#941) * docs(contributing): document the merge gate and the never-arriving-check trap On 2026-09-01 Vercel consolidated its commit-status contexts from one per project (`Vercel – threadplane`, `Vercel – threadplane-minting-service`) to a single `Vercel`. Branch protection required the literal old string, so the required check stopped arriving and every PR became permanently unmergeable while showing all checks green — `MERGEABLE` + `BLOCKED`, indistinguishable from a slow queue. That cost a lot of confused debugging, and the diagnostic is one API call once you know to make it. Adds a "The merge gate" section covering: - what the single required check is (`CI — required`, the `required-pr-checks` job, app-pinned to 15368, strict), and that `approve` must never join it; - why the gate is a job we own rather than a vendor status string a third party can rename out from under us; - the diagnostic — diff the contexts posted on the head SHA against the contexts protection requires — including the check-runs/statuses API split that makes `CI — required` absent from `/status`; - the pre-2026-09-01 protection config as a rollback reference, since branch protection is not version-controlled and needs an admin token to read. Deliberately no CI guard asserting protection matches the file: reading branch protection needs `administration: read`, which the workflow `permissions:` key cannot grant, so it would require a long-lived admin PAT in Actions secrets. That credential is a worse risk than the drift it catches. Reasoning is recorded in the section so the next person doesn't re-derive it. Verified against the API while writing: f927124 carries the two old contexts (minting-service failing), a8a603f carries the single `Vercel`, and `CI — required` is a check run from app 15368. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(contributing): record why the Vercel status stays non-required Reviewed 2026-09-01. States the residual gap plainly — a Vercel-environment- specific failure is not caught pre-merge, only post-merge by `Deploy → Vercel` — and why requiring the status back was rejected: the consolidated `Vercel` context now covers every project, so it would let an unrelated project block a pure-website PR, reversing the #931 behaviour. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npx nx test scripts --skip-nx-cachegit diff --check origin/main...HEAD