test(website): fix the e2e main broke, and drop the obsolete next-env wrapper - #870
Merged
Merged
Conversation
… wrapper Two related repairs to the website e2e lane: 1. Docs search spec: #865's a11y pass gave search results role="option", and an explicit ARIA role overrides the implicit button role — so getByRole('button') stopped matching and main's website e2e has been red since. The spec now queries role 'option'. (Verified the failure reproduces identically on pristine main before touching anything.) 2. run-e2e-with-next-env-restore.ts existed to rewrite next-env.d.ts to canonical content after e2e, protecting a then-tracked file from dirty- tree churn. #862 untracked the file, and the dangling dev-path content the wrapper guarded against breaks nothing today — verified by writing that exact content with the referenced path absent: lint 0, test 0, build 0 (website has no typecheck target, and build regenerates the file first). The e2e target now runs the playwright executor directly; the wrapper and its extra target indirection are gone. Website e2e: 49/49 with the folded target. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
blove
enabled auto-merge (squash)
August 30, 2026 14:43
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started as follow-up cleanup, turned into a main-is-red fix.
1. Main's website e2e is currently red
While verifying the cleanup I found
Docs search › matches docs pages when query omits small connector wordsfailing — and failing identically on pristine main (verified before touching anything). Cause: #865's a11y pass gave search resultsrole="option", and an explicit ARIA role overrides the implicit button role, sogetByRole('button', …)stopped matching. SinceWebsite — e2eis in the required aggregation, every website-touching PR fails until this lands. The spec now queriesrole: 'option'; the siblinggetByRole('button')uses in other specs are real buttons and untouched.2. The next-env restore wrapper is obsolete
run-e2e-with-next-env-restore.tsrewrotenext-env.d.tsto canonical content after e2e — protection for a then-tracked file against dirty-tree churn (its originating commit was workflow hygiene). #862 untracked the file. I verified the residual concern is empty before deleting: wrote the exact dangling dev-path content the wrapper guards against, with the referenced path absent —lint0,test0,build0 (the website has no typecheck target, and build regenerates the file first).The
e2etarget now runs the playwright executor directly; thee2e-playwrightindirection is folded away. CI's invocation (npx nx e2e website --skip-nx-cache) is unchanged.Verification
🤖 Generated with Claude Code