feat(design-tokens): generate tokens-dark.css for the dark-designed cockpit apps - #867
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
blove
enabled auto-merge (squash)
August 30, 2026 14:15
Contributor
blove
force-pushed
the
blove/tokens-dark-css
branch
from
August 30, 2026 14:15
5cfedb3 to
79be31d
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
…ockpit apps The third post-arc follow-up, foundation half. Investigation found the cockpit example apps' var(--ds-*, fallback) fallbacks are hand-copies of darkOverrides (verified value-by-value: #111 canvas, #f5f5f5 text, #64c3fd accent = the dark-theme semantic accent) with the same minor drift tokens.css had (e.g. accentBorder 0.25 vs the token's 0.2). So the wiring target for those apps is a DARK tokens file - importing the light tokens.css would flip deliberately dark apps to light. buildTokensBlock is parameterized by theme overrides (light/dark key parity is already enforced by tokens.spec.ts); tokens-dark.css joins the generator, the byte-identical drift guard (mutation-tested: a changed dark value goes red), the light/dark name-parity check, the package exports, and the build assets. No consumer is wired yet - that is the per-app visual-judgment half, tracked separately. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blove
force-pushed
the
blove/tokens-dark-css
branch
from
August 30, 2026 14:20
79be31d to
fbbe124
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Foundation half of the last post-arc follow-up. Investigating "wire cockpit apps to
tokens.css" found the premise wrong: the cockpit apps'var(--ds-*, fallback)fallbacks are hand-copies ofdarkOverrides—#111canvas,#f5f5f5text,#64c3fdaccent (the dark-theme semantic accent) — with the same minor drifttokens.cssitself had before #845 (e.g.accentBorder0.25 vs the token's 0.2). Wiring the lighttokens.csswould flip deliberately-dark example apps to light.So:
tokens-dark.css, generated fromdarkOverridesby the same guarded pipeline.buildTokensBlockparameterized by theme (light/dark key parity already enforced bytokens.spec.ts).--ds-*name-parity check.@threadplane/design-tokens/tokens-dark.css, shipped by the build (verified indist/).theme.cssandtokens.cssbyte-unchanged.What this deliberately does not do
No cockpit app is wired yet. That half is per-app visual judgment — each import makes the drifted fallbacks dead text, which is a small visible change on deployed demos — and is tracked as its own task.
🤖 Generated with Claude Code