chore: remove dead surfaces and fix two demo defects from the docs reviews - #1039
Merged
Conversation
… found
- @threadplane/chat no longer exports ./chat.css: ng-package globbed a
file that has never existed, so the published subpath resolved nothing.
- A2uiSlotDirective and its spec are deleted; the surface renders through
surfaceToSpec + <render-spec> and nothing imported the directive.
- marked moves from cockpit-shell (which never imports it) to the root
devDependencies, where it satisfies @threadplane/chat's peer for the
workspace; the chat peer itself stays because markdown-render.ts loads
marked dynamically.
- getInterrupt's JSDoc showed agent.resume(), which does not exist; the
example now uses submit({ resume }).
- The messages demo no longer resubmits from (submitted); the threads demo
no longer binds [threads] to <chat>, which rendered a second thread list
on desktop. The message-model and thread-routing pages describe the
fixed demos; api-docs.json regenerated.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
blove
enabled auto-merge (squash)
September 6, 2026 21:17
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the example-first docs program (#1025–#1038). The page reviews surfaced dead code and two demo defects; this PR removes and fixes them.
Dead surfaces removed
@threadplane/chatexported./chat.cssandng-package.jsonglobbed it, but no such file exists undersrc/lib/styles. The export and the glob are gone.A2uiSlotDirective(+ spec) was the superseded slot-based progressive renderer;<a2ui-surface>renders throughsurfaceToSpec+<render-spec>and nothing imported it. Comments insurface.component.tsupdated.markedwas declared inlibs/cockpit-shell/package.jsonbut never imported there. It is now a root devDependency, which is what actually satisfies@threadplane/chat's peer for the workspace builds. The chat peer stays:markdown-render.tsloadsmarkeddynamically. The lockfile change is limited to the moved entry (verified against the pre-regeneration copy; Linux swc bindings intact).getInterrupt's JSDoc example calledagent.resume('approved'), a method that does not exist; it now showsagent.submit({ resume: 'approved' }).api-docs.jsonregenerated.Demo defects fixed
(submitted)handler calledagent.submit()a second time after<chat-input>had already submitted. The binding and handler are removed; the message-model page no longer describes the demo as defective.[threads]/[activeThreadId]to<chat>AND mounted its own<chat-thread-list>, so desktop viewports showed two lists.<chat>now takes only the agent; the thread-routing page explains the built-in list as an option the demo leaves unbound.Left alone, on purpose:
--tplane-chat-radius-input(declared, read by consumers such as the example layouts, documented as such);unarchivein the threads demo (wired, unreachable without an archived list); the chat-debug demo's lack of a composer (by design).Verification:
nx run-many -t lint,test,build --projects=chat,cockpit-shellgreen; website unit specs 1290/1290 (positioning guard passes with the peer restored);cockpit-chat-messages-angularandcockpit-chat-threads-angularbuild and e2e green;generate-api-docsno further drift.🤖 Generated with Claude Code