Skip to content

fix(website): pin the stage hold one millisecond inside it so the frame reports pause #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blove merged 2 commits into from
Sep 6, 2026
Merged

fix(website): pin the stage hold one millisecond inside it so the frame reports pause #1034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d8a785
fix(website): pin the stage hold one millisecond inside it so the fra…
blove Sep 6, 2026
709b458
fix(website): the pre-hold ramp ends on the pinned hold value so the …
blove Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/website/src/lib/stage-beats.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,10 @@ describe('timeAt', () => {
it('pins time at the interrupt through the hold and resumes past the threshold', () => {
const a = beatWindows()[2];
const at = (f: number) => timeAt(a.from + (a.to - a.from) * f, READY);
expect(at(APPROVE_HOLD.from)).toBe(READY.hold.startMs);
expect(at(0.5)).toBe(READY.hold.startMs);
expect(at(APPROVE_HOLD.to - 1e-6)).toBe(READY.hold.startMs);
// Pinned one millisecond inside the hold, so the frame reports `pause`.
expect(at(APPROVE_HOLD.from)).toBe(READY.hold.startMs + 1);
expect(at(0.5)).toBe(READY.hold.startMs + 1);
expect(at(APPROVE_HOLD.to - 1e-6)).toBe(READY.hold.startMs + 1);
expect(at(APPROVE_HOLD.to)).toBe(READY.hold.endMs);
expect(at(1)).toBe(READY.beats[2].endMs);
});
Expand Down
10 changes: 6 additions & 4 deletions apps/website/src/lib/stage-beats.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,13 @@ export function timeAt(p: number, ready: StageReadyMessage): number {
: Math.round(lerp(mid, b.endMs, (f - 0.5) / 0.5));
}
case 'approve': {
const holdPin = Math.min(ready.hold.startMs + 1, ready.hold.endMs);
if (f < APPROVE_HOLD.from)
return Math.round(
lerp(b.startMs, ready.hold.startMs, f / APPROVE_HOLD.from)
);
if (f < APPROVE_HOLD.to) return ready.hold.startMs;
return Math.round(lerp(b.startMs, holdPin, f / APPROVE_HOLD.from));
// One millisecond INSIDE the hold: the frame treats a boundary instant as
// belonging to the outgoing run (phaseReachedAt subtracts an epsilon), so
// pinning at hold.startMs exactly would report `stream`, not `pause`.
if (f < APPROVE_HOLD.to) return holdPin;
return Math.round(
lerp(
ready.hold.endMs,
Expand Down
Loading