Skip to content

docs(render): six guides teach through their running examples - #1033

Merged
blove merged 14 commits into
mainfrom
blove/docs-example-first-render
Sep 6, 2026
Merged

docs(render): six guides teach through their running examples#1033
blove merged 14 commits into
mainfrom
blove/docs-example-first-render

Conversation

@blove

@blove blove commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

PR 4 of the example-first docs program (plan: docs/superpowers/plans/2026-09-06-docs-example-first-products.md, PR 4 table; spec: docs/superpowers/specs/2026-09-05-docs-example-first-content-design.md).

Pages rewritten (repeat-loops was a 10-line stub): render/api/{provide-render,render-spec-component} (reference tables kept and corrected) and render/guides/{registry,repeat-loops,specs,state-store}.

Walkthroughs deleted: the six cockpit/render/*/python/docs/guide.md files; PENDING_PAGES drops the six render entries (21 remain).

Example sources: comment-only #region markers in six components (inline-template markers included; each example project builds); one hint string in the repeat-loops demo no longer claims keyed reconciliation.

Facts settled (each verified in libs/render/src and @json-render/core): <render-spec> mounts only spec.root and recursion is opt-in via childKeys; store resolution is input > config > internal store created once from spec.state; registry resolution is input > config > VIEW_REGISTRY > empty; repeat.key and watch are schema-level and inert in the Angular renderer; visible is not evaluated on the element that carries repeat; $computed takes a record of args (the walkthroughs taught positional args and a compute key that do not exist); the spec format is flat (root + elements, children: string[]); the render examples' graph.py is a single-node chat graph outside the render path.

Known gap recorded: the repeat-loops example ships the array half only (its specs enumerate rows literally); the page says so and a follow-up should add a real repeat element to one spec.

Verification: nx run-many -t test,lint green (website, cockpit-registry, cockpit-shell, scripts); generators no drift; prod build renders every page with data-example-file counts equal to tag counts; nx e2e website 121 passed.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Sep 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
threadplane Ignored Ignored Preview Sep 6, 2026 5:09am UTC

Request Review

@blove
blove enabled auto-merge (squash) September 6, 2026 05:04

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

blove and others added 14 commits September 5, 2026 22:08
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… type

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…self-contained

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ghter registry region

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…e methods; who subscribes

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…luated; the demo ships the array half

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…arses; the demo's spec quoted verbatim

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@blove
blove force-pushed the blove/docs-example-first-render branch from b7ae173 to 8afd3fd Compare September 6, 2026 05:08
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@blove
blove merged commit 0255f87 into main Sep 6, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant