Skip to content

feat(growth): explain company capture failures - #1015

Merged
blove merged 2 commits into
mainfrom
blove/growth-capture-v1
Sep 5, 2026
Merged

feat(growth): explain company capture failures#1015
blove merged 2 commits into
mainfrom
blove/growth-capture-v1

Conversation

@blove

@blove blove commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Company acquisition previously returned empty evidence without explaining whether a page was oversized, unavailable, timed out, or rejected by the redirect policy. Add optional bounded per-page diagnostics and retain them in local pilot acquisition reports, including diagnostics emitted before a company capture fails.

The existing evidence return type, fetch limits, redirect rules, SSRF controls, cancellation behavior, and outreach behavior remain unchanged. Diagnostic observers cannot change capture outcomes. Records contain outcome codes, original requested paths, HTTP status, and known byte counts, without raw errors, bodies, or redirect URLs.

Validation: lifecycle and growth-research tests, checks, lint, and builds passed. Focused regression suites passed 71 lifecycle and 4 acquisition tests. A six-company live acquisition reproduced rejected redirects, oversized HTTP 200 pages, and genuine 404s with explicit diagnostics. Independent spec and code reviews passed.

A separate local Firecrawl capture experiment recovered 16/18 requested pages across all six companies, compared with 5 pages across three companies for direct capture. It made no model calls and adds no production provider integration or dependency in this PR.

@vercel

vercel Bot commented Sep 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
threadplane Ready Ready Preview Sep 5, 2026 6:58pm UTC

Request Review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@blove
blove merged commit d5918a2 into main Sep 5, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant