Skip to content

refactor: workspace surface rename — hooks, classes, labels, assets - #1013

Closed
blove wants to merge 3 commits into
mainfrom
blove/workspace-surface-rename
Closed

refactor: workspace surface rename — hooks, classes, labels, assets#1013
blove wants to merge 3 commits into
mainfrom
blove/workspace-surface-rename

Conversation

@blove

@blove blove commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Part B of docs/superpowers/specs/2026-09-04-docs-workspace-unification-design.md (plan: docs/superpowers/plans/2026-09-04-docs-workspace-unification.md).

What

  • Every data-cockpit-* hook becomes data-workspace-* (data-cockpit-workspacedata-workspace-surface), every .cockpit-* class, BEM variant, CSS custom property, and keyframe becomes workspace-*, across libs/workspace-react and apps/website, with the Playwright specs, style contract, and screenshot capture script updated in the same commit. The CSS is byte-identical modulo the token substitution.
  • Sidebar landmark aria-label Cockpit navigationDocumentation navigation.
  • Screenshot assets renamed workspace-{run,code,docs,api}.webp.
  • Nine prose mentions in blog and docs reworded; the chat-debug row says "Debug panel".
  • New guard in cockpit-retirement.spec.ts: the bare word must not appear in user-facing Website copy (.mdx, .md, .tsx), with a narrowly scoped allowlist for repository paths, package and project names, bridge query params, and type names.

Internal package names, Nx project names, cockpit/ example directories, file names, and CI keys are unchanged by design.

Verification

Website unit suite 1213/1213 (guard green); workspace-react and cockpit-shell green; lint 0 errors; npx nx e2e website 122 passed locally. The deployed-preview lane proves the renamed selectors against a real preview.

Follow-ups: Part C (redirect service retirement), Part D (Vercel/DNS/secrets cleanup). Guard follow-up noted in review: scanning .ts copy modules and the library needs a literal-only design, not the current line scrub.

🤖 Generated with Claude Code

blove and others added 3 commits September 5, 2026 09:51
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…the run-mode placeholder

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
threadplane Ready Ready Preview Sep 5, 2026 5:14pm UTC

Request Review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant