Add support for named implements in Go#1657
Open
jfleitz wants to merge 4 commits into
Open
Conversation
Signed-off-by: Jeremy Fleitz <jeremy@cosmonic.com>
Signed-off-by: Jeremy Fleitz <jeremy@cosmonic.com>
Signed-off-by: Jeremy Fleitz <jeremy@cosmonic.com>
Signed-off-by: Jeremy Fleitz <jeremy@cosmonic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1642
Overview
In the scenario where you are importing the same interface under multiple names (implements feature in wasm), the Go generator only emitted the interface types from the first package, since there is a check for not adding a duplicate interface.
This change adds the Go package name to the Hash key instead of just
TypeId, allowing for all interfaces to be exported in all packages. There is no concern on duplicate interfaces in the same package, since that would be a Go compile error.C++ bin gen was also changed to support the implements feature as well, with using the derived namespace in the WorldKey (
primary::Bucket,secondary::Bucket).Testing
tests/codegen/issue1642.witimporting the same interface with two names (to test implements) as well as non-named (to test prior functionality)wit-bindgen goand re-generated the bindings for the implements-test project.Signed-off-by: Jeremy Fleitz jeremy@cosmonic.com