fix(wkg): respect member manifests during fetch - #244
Open
subotac wants to merge 1 commit into
Open
Conversation
mkatychev
reviewed
Jul 31, 2026
| let root = Manifest::load_root_workspace(&cwd).await?; | ||
| let mut root = Manifest::load_root_workspace(&cwd).await?; | ||
| if root.as_ref().is_some_and(|root| root.root_dir() != cwd) | ||
| && tokio::fs::try_exists(cwd.join(MANIFEST_FILE_NAME)).await? |
Member
There was a problem hiding this comment.
Would this approach work if one is in a subdirectory of a member manfiest, for instance, will this work if we are in subdir?
./root
├── member
│ ├── subdir
│ │ └── file.wit
│ └── wkg.toml
└── wkg.toml
Manifest::load_root_workspace will keep walking up the path until it finds a manifest that is a workspace root.
It may be better to handle this using find_root_manifest_for_wd:
wasm-pkg-tools/crates/wasm-pkg-core/src/manifest/paths.rs
Lines 6 to 7 in 3d79978
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #243.
When
wkg fetchran below a workspace root, it always selected workspace mode even when the current directory had its ownwkg.toml. Use the member manifest as the fetch context in that case while preservingworkspace behavior when no local manifest exists.
The regression test verifies that fetching from a member creates the member lock file rather than a workspace lock file.
Testing
cargo test -p wkg --test e2e fetch_from_member_manifest_uses_member_context --no-default-featurescargo check -p wkg --tests --no-default-featurescargo test -p wkg --bin wkg --no-default-featurescargo fmt --all -- --check