Require F_ALLOCATEALL on Apple fallocate - #1699
Open
mamicicekel wants to merge 1 commit into
Open
mamicicekel wants to merge 1 commit into
mamicicekel wants to merge 1 commit into
Conversation
F_PREALLOCATE without that flag can return success after reserving only a few megabytes. The next ftruncate then leaves a sparse file that later writes can hit ENOSPC on. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apple's
F_PREALLOCATEwithoutF_ALLOCATEALLmay succeed after allocating only part offst_lengthand reports the actual amount infst_bytesalloc. rustix treated any non--1return as a full reservation, thenftruncated, sofallocatecould returnOk(())after reserving a few MiB of a much larger request.The contiguous attempt now includes
F_ALLOCATEALL. If that fails, the non-contiguous retry still usesF_ALLOCATEALLand no longer ignores a failedfcntl.Fixes #1682.
Test plan
cargo test --features=fs --test fs apple_fallocateon macOS ARM (APFS)Made with Cursor