Skip to content

Move the Claude Code mod and hook into an uploads-mod plugin - #1428

Merged
Zach Dunn (zachdunn) merged 2 commits into
mainfrom
claude/project-thread-qh0h4t
Nov 20, 2026
Merged

Zach Dunn (zachdunn) merged 2 commits into
mainfrom
claude/project-thread-qh0h4t

Conversation

@zachdunn

Copy link
Copy Markdown
Member

Requested by Zach · project thread

Why

The Claude plugin directory only accepts command hooks, mods (modules in hooks.json), and .sh/.ts/.tsx files from Verified organizations. We aren't one, so plugins/claude/uploads is refused. This PR keeps that folder to skills plus the hosted MCP server. The mod and the pre-PR reminder hook move into a second plugin, which only our own marketplace lists.

What changed

  • New plugins/claude/uploads-mod/: moved hooks/ (hooks.json, register.tsx, its test, pre-pr-screenshot.sh) and types/ here. It gets its own manifest (with the autoPromote userConfig), a README with the mod's data and network disclosures, and the icon. Mod state keys are renamed from uploads.* to uploads-mod.*, because the validator only lets the plugin that owns a key write it.
  • Slim plugins/claude/uploads/: removed types and userConfig from plugin.json and the hook and mod sections from the README. It now holds skills, .mcp.json, the README, plugin.json, and the PNG icon.
  • .claude-plugin/marketplace.json: now lists both plugins. The version sync and check scripts cover every entry and the new manifest. Root plugin.json points its hooks at the new path.
  • Skills (root + synced copy):
    • The curl -T line in uploads-cli and github-screenshots now spells out the URL, an HTTPS PUT to https://agents.uploads.sh/u/<ticket>. This fixes the LAUNCHER_REGISTRY_REDIRECT blocker.
    • Dropped npx @buildinternet/uploads --help, and swapped npx playwright install chromium for a link to Playwright's docs (RUNTIME_FETCH_EXEC warnings).
  • Docs: oxlint paths, docs/releasing.md, AGENTS.md, the agents docs page, the screenshots guide, llms.txt, and the root README.
  • Changeset: a minor @uploads/plugin bump.

Impact

People who installed from our marketplace lose the staged media band and the reminder on their next update. To get them back they run /plugin install uploads-mod@uploads. The changeset and docs say this. Codex is unaffected because it uses the repo-root hooks/, and so is Grok, which gets the reminder from uploads install.

Testing

  • claude plugin validate --strict plugins/claude/uploads passes with nothing to report.
  • claude plugin validate --strict plugins/claude/uploads-mod passes.
  • claude plugin test plugins/claude/uploads-mod: 46 pass.
  • pnpm plugin-version:check and pnpm plugin-skills:check pass.
  • Before merging, also run the portal check: Submit new → Plugin bundle → buildinternet/uploads@claude/project-thread-qh0h4t, path plugins/claude/uploads, Validate, and leave without submitting.

Generated by Claude Code

The Claude directory refuses command hooks, mods, and .sh/.ts/.tsx files
from orgs that aren't Verified. Keep plugins/claude/uploads to skills and
the hosted MCP server, and list the mod + reminder hook as a second plugin
in our own marketplace. Also spell out the upload URL instead of a bare
curl line in the skills and drop the npx run-once lines.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KeLbkf16ND31pqA7SCKjPm
@changeset-bot

changeset-bot Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2aaf4fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@uploads/plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 2

  • coderabbit:review
  • review
🚫 Excluded labels (none allowed): 1

  • wip

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 86a16a1a-df87-43f1-8070-9bdb9c8c491c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@zachdunn Zach Dunn (zachdunn) self-assigned this Nov 20, 2026
@uploads-sh

uploads-sh Bot commented Nov 20, 2026

Copy link
Copy Markdown

No uploads on this PR yet

This PR changes UI files (plugins/claude/uploads-mod/hooks/register.tsx). Screenshots help reviewers see what changed.

  • From the CLI: uploads put before.png after.png --pr 1428
  • From an agent: ask it to attach screenshots with uploads.sh
  • By hand: drag images into the PR description and they're imported automatically
Tips for agents

Label each shot so reviewers know what they're seeing. Labels apply to every file in a call, so run one put per shot:

uploads put after.png --pr 1428 --meta path=/settings --state after --caption "Saved settings toast"
uploads put chat.png --pr 1428 --app ios --screen "Chat" --state after

No CLI? With the Uploads MCP, call sign_upload_url for files on disk (or put) with repo, pr: 1428 and the same screen, state and caption fields.

This comment updates with each upload, so you don't need to post the images yourself. A shot or two in the PR description is still welcome. Check what's attached with uploads list --pr 1428. More in the github-screenshots skill or the agent docs.

Workspace admins can turn this comment off in Settings → GitHub · docs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KeLbkf16ND31pqA7SCKjPm
@zachdunn
Zach Dunn (zachdunn) merged commit 18b81c5 into main Nov 20, 2026
4 checks passed
@zachdunn
Zach Dunn (zachdunn) deleted the claude/project-thread-qh0h4t branch November 20, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants