Repository navigation
Require AUTH_INTERNAL_KEY on uploads-mcp - #1427
Conversation
uploads-mcp runs api's uploader-identity code, which calls auth's /internal/users/:id/github-account over the AUTH binding. Auth hides /internal/* behind the shared key and answers 404 without it. The secret was missing on uploads-mcp from Nov 4 (#1389) until Nov 20, so hosted MCP uploads lost uploader attribution and GitHub-access routing. List it as required so a deploy without it fails instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeLbkjH2S4CZ2Lq8LpfA8P
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 2
🚫 Excluded labels (none allowed): 1
Please check the settings in the CodeRabbit UI or the
|
Requested by Zach · project thread
Summary
uploads-mcpruns api'suploader-identity.ts, which calls auth's/internal/users/:id/github-accountover theAUTHservice binding. Since #1389, auth only answers/internal/*when the sharedAUTH_INTERNAL_KEYmatches, and returns 404 otherwise. The secret was set on api and auth but not on mcp. So every hosted MCP lookup 404'd ("uploader login resolution failed" / "uploader account-id resolution failed" in Workers logs). Hosted MCP uploads lostgh.uploaderattribution, routing by GitHub write access, and the PR actor check. The errors only became visible after #1422 stopped caching the 404 as "no linked account".The secret is now set on
uploads-mcp(Nov 20). This PR:AUTH_INTERNAL_KEYtosecrets.requiredinapps/mcp/wrangler.jsonc, so a deploy without it fails instead of silently degrading (same treatment as api)apps/mcp/src/env.d.tsnext toWORKSPACE_SECRETS_KEYTest plan
wrangler typesfor mcp now emitsAUTH_INTERNAL_KEY: stringuploads-mcpscript before opening this PR, so the required check won't block the deploy on mergeGenerated by Claude Code