Skip to content

Require AUTH_INTERNAL_KEY on uploads-mcp - #1427

Merged
Zach Dunn (zachdunn) merged 1 commit into
mainfrom
claude/project-thread-1y1gih
Nov 20, 2026
Merged

Zach Dunn (zachdunn) merged 1 commit into
mainfrom
claude/project-thread-1y1gih

Conversation

@zachdunn

Copy link
Copy Markdown
Member

Requested by Zach · project thread

Summary

uploads-mcp runs api's uploader-identity.ts, which calls auth's /internal/users/:id/github-account over the AUTH service binding. Since #1389, auth only answers /internal/* when the shared AUTH_INTERNAL_KEY matches, and returns 404 otherwise. The secret was set on api and auth but not on mcp. So every hosted MCP lookup 404'd ("uploader login resolution failed" / "uploader account-id resolution failed" in Workers logs). Hosted MCP uploads lost gh.uploader attribution, routing by GitHub write access, and the PR actor check. The errors only became visible after #1422 stopped caching the 404 as "no linked account".

The secret is now set on uploads-mcp (Nov 20). This PR:

  • adds AUTH_INTERNAL_KEY to secrets.required in apps/mcp/wrangler.jsonc, so a deploy without it fails instead of silently degrading (same treatment as api)
  • declares it in apps/mcp/src/env.d.ts next to WORKSPACE_SECRETS_KEY

Test plan

  • wrangler types for mcp now emits AUTH_INTERNAL_KEY: string
  • Confirmed the secret exists on the uploads-mcp script before opening this PR, so the required check won't block the deploy on merge
  • CI green

Generated by Claude Code

uploads-mcp runs api's uploader-identity code, which calls auth's
/internal/users/:id/github-account over the AUTH binding. Auth hides
/internal/* behind the shared key and answers 404 without it. The
secret was missing on uploads-mcp from Nov 4 (#1389) until Nov 20, so
hosted MCP uploads lost uploader attribution and GitHub-access routing.
List it as required so a deploy without it fails instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KeLbkjH2S4CZ2Lq8LpfA8P
@changeset-bot

changeset-bot Bot commented Nov 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4f82eaa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 2

  • coderabbit:review
  • review
🚫 Excluded labels (none allowed): 1

  • wip

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4f1c64b8-34bd-45b0-aab4-f5be7a120fae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@zachdunn Zach Dunn (zachdunn) self-assigned this Nov 20, 2026
@zachdunn
Zach Dunn (zachdunn) merged commit e7701f2 into main Nov 20, 2026
4 checks passed
@zachdunn
Zach Dunn (zachdunn) deleted the claude/project-thread-1y1gih branch November 20, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants