Repository navigation
Adopt iOS SDK 7.0.0 (stable) - #182
Conversation
Pin bugsee/spm and feedback-spm to 7.0.0 and regenerate Package.resolved. 7.0.0 moved the wrapper SPI (BGSReportContract, BGSWrapperChannel) out of the Bugsee umbrella, so import Bugsee/BugseeSPI.h where it is used. max-pending-reports and max-pending-report-age are now shared keys: move their accessors to the base options class and enable the iOS effect test. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
No actionable comments were generated in the recent review.
|
# Conflicts: # packages/react-native/ios/BugseeModule.mm # packages/react-native/ios/Support/Sources/BugseeRNSupport/include/BGSRNReportHandlerBridge.h # packages/react-native/ios/Support/Sources/BugseeRNSupport/include/BGSRNReportOps.h # packages/react-native/ios/Support/Sources/BugseeRNSupport/include/BGSRNWrapperChannelHolder.h # packages/react-native/ios/Support/Tests/BugseeRNSupportTests/BGSRNFakeReport.h # packages/react-native/ios/Support/Tests/BugseeRNSupportTests/BGSRNReportHandlerBridgeTests.m # packages/react-native/ios/Support/Tests/BugseeRNSupportTests/BGSRNWrapperChannelHolderTests.m
|
Claude finished @krassx's task in 54s —— View job Review of PR #182: Adopt iOS SDK 7.0.0 (stable)
I found no real bugs, so there are no inline comments. I read the code only. What I checked
Minor notes (not blocking)
Not covered (agreeing with the PR description)The SwiftPM delivery path and the Archive/symbolication path are untested with the new SPI import. The Summary
|
Summary
Adopt the stable iOS SDK 7.0.0 (was 7.0.0-beta7).
bugsee/spmandbugsee/feedback-spmto7.0.0; regeneratePackage.resolved(revisionbbfdda2); updatenative-versions.json, docs and the tests that assert the pin.BGSReportContract,BGSWrapperChannel) out of theBugseeumbrella intoBugsee.SPI. Without an explicit import the Support package no longer compiles. Added#import <Bugsee/BugseeSPI.h>where it is used, and@import Bugsee.SPI;in three test files.max-pending-reportsandmax-pending-report-age, which the wrapper treated as Android-only. Moved both to the shared key set and their accessors to the base options class (as was done formaxDataSize), and enabled themax-pending-reportseffect test on iOS.Testing
BugseeRNSupport, iPhone 17 Pro simulator): 351 pass.BareExamplebuilds against 7.0.0; embed assertion passes.Known failures, not caused by this change
secure-component"unmounting disposes the mask": fails identically on cleanmainwith beta7 (simulator baseline).secure-perf: p95 timing budgets miss in a Debug build on the simulator and on the device (not baselined against beta7). Debug-only budget problem; not run in Release.Not covered
Android e2e (unaffected), the SwiftPM delivery path (the new SPI import is untested there), and the Archive/symbolication path.
🤖 Generated with Claude Code