Repository navigation
feat(core)!: model the streaming reader resume position inside stored data-descriptor entries - #690
Merged
Merged
Conversation
… data-descriptor entries verify, list and extract now scan the declared range of a stored entry that carries a data descriptor for a descriptor signature and search from there like a gap, so a header or stray record that a streaming reader resumes on is reported under Enforce. Compressed entries stay covered by verify --check-integrity. BREAKING CHANGE: ZIP archives with a hidden local header or stray record signature in the declared range of a stored data-descriptor entry are rejected under Enforce.
github-actions
Bot
added
core
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The resume model added with #683 reads only at the end a data-descriptor entry declares in the central directory. A streaming reader of a stored entry can resume earlier, inside the declared range.
verify,listandextractnow scan the declared range of a stored entry that carries a data descriptor for a descriptor signature and search from there like a gap, reusing the existing census gap search (HiddenLocalHeader, regionDescriptorTail, plus stray record findings). A header may end anywhere before the central directory.verify --check-integrity; the stored branch of that check is replaced by the census scan.--zip-consistency ignorefor trusted producers.skills/exarch-cli/SKILL.mdand spec 017 are updated.Closes #687