Repository navigation
Merge PTAAA-881-fix-selfheal-warning-gate - #329
Merged
bsautomation merged 2 commits intoNov 2, 2026
Merged
Conversation
The warning added in #315 fires when shouldAddServiceVersion() returns false, but that has two independent causes: not being on BrowserStack infra, and using the chromedriver service with testObservability left on. A genuine BrowserStack session in the second case is told it is not running on BrowserStack infrastructure. Gate on isBrowserstackInfra() instead — the condition the message actually describes. It is already imported here for the same purpose a few lines above. shouldAddServiceVersion stays for its other callers. Found while porting #315 to v8 (#322), which has the corrected gate. Typecheck unchanged at 9 pre-existing errors; tests unchanged at 931 passing / 29 pre-existing failures. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
bsautomation
requested review from
07souravkunda and
AakashHotchandani
and removed request for
a team
November 2, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge into sdk_v9_pre_prod :by automationbs
main)