Skip to content

ci: pin gem-push workflow actions to immutable commit SHAs #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
07souravkunda merged 1 commit into from
Sep 24, 2026
Merged

ci: pin gem-push workflow actions to immutable commit SHAs #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/gem-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ jobs:
id-token: write

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3

@07souravkunda 07souravkunda Sep 21, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] The PR description says "each pinned SHA is the commit the corresponding tag resolves to today." That's exact for ruby/setup-ruby (@v1 → a0102e0 / v1.324.0) and configure-rubygems-credentials (@v2.0.0 → 762a4b7), but not for actions/checkout: @v3 currently resolves to a37ce91… (v3.6.0), whereas this pins c85c95e… (v3.5.3). Pinning v3.5.3 is a deliberate, good choice — it matches the SHA the repo's own Semgrep.yml already pins, and v3.5.3→v3.6.0 is immaterial to gem build/gem push — so no code change is needed. Just consider tightening the wording (e.g. "SHAs are known-good tag versions; checkout is pinned to the same v3.5.3 as Semgrep.yml") so a future reader isn't surprised it isn't the current @v3 tip. Non-blocking.

- name: Set up Ruby 2.6
uses: ruby/setup-ruby@v1
uses: ruby/setup-ruby@a0102e0972be65f351c307e2d64b9314a57c8073 # v1.324.0
with:
ruby-version: 2.6.10

- uses: rubygems/configure-rubygems-credentials@v2.0.0
- uses: rubygems/configure-rubygems-credentials@762a4b77c3300434bb57c7ce80b20e36231927aa # v2.0.0
- name: Build and push gem
run: |
gem build *.gemspec
Expand Down
Loading