Skip to content

fix(cli): hide Windows daemon console window - #2928

Open
dvd233 wants to merge 1 commit into
browserbase:v3from
dvd233:fix/browse-daemon-windows-hide-2918
Open

fix(cli): hide Windows daemon console window#2928
dvd233 wants to merge 1 commit into
browserbase:v3from
dvd233:fix/browse-daemon-windows-hide-2918

Conversation

@dvd233

@dvd233 dvd233 commented Sep 12, 2026

Copy link
Copy Markdown

why

On Windows, the detached Browse driver daemon starts without windowsHide, so headless sessions briefly flash a console window and can steal focus from the user's terminal or editor. This is the behavior reported in #2918.

what changed

  • Pass windowsHide: true when spawning the detached driver daemon.
  • Add a regression test that exercises daemon startup and asserts the complete spawn contract.
  • No changeset is included because the repository changeset config ignores the browse package.

test plan

  • pnpm --filter browse test -- daemon-spawn.test.ts
  • pnpm exec prettier --check src/lib/driver/daemon/client.ts tests/daemon-spawn.test.ts
  • pnpm exec eslint src/lib/driver/daemon/client.ts tests/daemon-spawn.test.ts
  • pnpm check
  • git diff --check

The focused test, formatting, ESLint, and TypeScript checks pass. The full CLI suite also exposed four failures in unchanged telemetry tests under this Windows environment; they return 3221226505 instead of the expected exit code and are not related to the two changed files.


Summary by cubic

Fixes the Windows console flash and focus stealing from the detached Browse driver daemon (#2918) by passing windowsHide: true when spawning it. Also adds a regression test that asserts the full daemon spawn contract.

No changeset is included because the repository changeset config ignores the browse package.

Written for commit 9a29b5b. Summary will update on new commits.

Review in cubic

@changeset-bot

changeset-bot Bot commented Sep 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9a29b5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run.
Approving the latest commit mirrors it into an internal PR owned by the approver.
If new commits are pushed later, the internal PR stays open but is marked stale until someone approves the latest external commit and refreshes it.

@github-actions github-actions Bot added external-contributor Tracks PRs mirrored from external contributor forks. external-contributor:awaiting-approval Waiting for a stagehand team member to approve the latest external commit. labels Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor:awaiting-approval Waiting for a stagehand team member to approve the latest external commit. external-contributor Tracks PRs mirrored from external contributor forks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant