You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On Windows, the detached Browse driver daemon starts without windowsHide, so headless sessions briefly flash a console window and can steal focus from the user's terminal or editor. This is the behavior reported in #2918.
what changed
Pass windowsHide: true when spawning the detached driver daemon.
Add a regression test that exercises daemon startup and asserts the complete spawn contract.
No changeset is included because the repository changeset config ignores the browse package.
The focused test, formatting, ESLint, and TypeScript checks pass. The full CLI suite also exposed four failures in unchanged telemetry tests under this Windows environment; they return 3221226505 instead of the expected exit code and are not related to the two changed files.
Summary by cubic
Fixes the Windows console flash and focus stealing from the detached Browse driver daemon (#2918) by passing windowsHide: true when spawning it. Also adds a regression test that asserts the full daemon spawn contract.
No changeset is included because the repository changeset config ignores the browse package.
Written for commit 9a29b5b. Summary will update on new commits.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run.
Approving the latest commit mirrors it into an internal PR owned by the approver.
If new commits are pushed later, the internal PR stays open but is marked stale until someone approves the latest external commit and refreshes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
On Windows, the detached Browse driver daemon starts without
windowsHide, so headless sessions briefly flash a console window and can steal focus from the user's terminal or editor. This is the behavior reported in #2918.what changed
windowsHide: truewhen spawning the detached driver daemon.browsepackage.test plan
pnpm --filter browse test -- daemon-spawn.test.tspnpm exec prettier --check src/lib/driver/daemon/client.ts tests/daemon-spawn.test.tspnpm exec eslint src/lib/driver/daemon/client.ts tests/daemon-spawn.test.tspnpm checkgit diff --checkThe focused test, formatting, ESLint, and TypeScript checks pass. The full CLI suite also exposed four failures in unchanged telemetry tests under this Windows environment; they return
3221226505instead of the expected exit code and are not related to the two changed files.Summary by cubic
Fixes the Windows console flash and focus stealing from the detached Browse driver daemon (#2918) by passing
windowsHide: truewhen spawning it. Also adds a regression test that asserts the full daemon spawn contract.No changeset is included because the repository changeset config ignores the
browsepackage.Written for commit 9a29b5b. Summary will update on new commits.