fix DotExpr for fusions and improve missing field semantics - #7297
Open
mccanne wants to merge 1 commit into
Open
fix DotExpr for fusions and improve missing field semantics#7297mccanne wants to merge 1 commit into
mccanne wants to merge 1 commit into
Conversation
This commit makes DotExpr's work with fusion and nones. There is currently a slow-path defuse whenever a none value or missing-field error is encountered. We can improve this later. In making these changes, we realized it would be better semantics for a reference to a non-existent field always return an error even for the "?." operator. Instead, ok() with a none operator should be used when missing fields are expected. Ok-pushdown will be added in a subsequent PR where the defuse step required to create the structured error can be avoided when we know the dot operation is wrapped in an ok() or is_ok(). We added the flag to the DotExpr struct but still need to wire it up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes DotExpr's work with fusion and nones. There is currently a slow-path defuse whenever a none value or missing-field error is encountered. We can improve this later.
In making these changes, we realized it would be better semantics for a reference to a non-existent field always return an error even for the "?." operator. Instead, ok() with a none operator should be used when missing fields are expected.
Ok-pushdown will be added in a subsequent PR where the defuse step required to create the structured error can be avoided when we know the dot operation is wrapped in an ok() or is_ok(). We added the flag to the DotExpr struct but still need to wire it up.