Add -static flag - #7292
Conversation
|
One small finding: Right now it's possible to invoke |
|
Thanks Phil there should be an error if both are activated |
|
@mattnibs: Here's a more significant finding. Since you'd mentioned on Slack that this affected some SQL tests, I happened to do a proactive run of the sqllogic-ztests on this branch and it did hit some crashes, such as on select1/q0.yaml. I had Claude simplify the repro, and it came up with this one which also reproduces on this branch but not current tip of Claude also gave its stab at root cause and possible direction for a fix, so its notes are up in a Gist if that helps. |
d55bada to
66d5dc8
Compare
This commit adds the -static flag which when enabled, forces static type checking on all input files. By default csup and parquet are statically checked- all other file types are dynamic. If the -static flag is enabled the entire file is read and the full type information is gathered. Non-seekable inputs (e.g., /dev/stdin) cannot be statically checked an will return an error -static is enabled. This commit removes the -samplesize flag.
66d5dc8 to
e8589c1
Compare
|
Looks like that's fixed. Thanks @mattnibs! |
76d694a to
17ee62d
Compare
This commit adds the -static flag which when enabled, forces static type checking on all input files. By default csup and parquet are statically checked- all other file types are dynamic. If the -static flag is enabled the entire file is read and the full type information is gathered. Non-seekable inputs (e.g., /dev/stdin) cannot be statically checked an will return an error -static is enabled.
This commit removes the -samplesize flag.