Skip to content

feat!: remove the discover command and Discover API integration - #25

Open
nirsha-brd wants to merge 1 commit into
brightdata:mainfrom
nirsha-brd:remove-discover-api
Open

feat!: remove the discover command and Discover API integration#25
nirsha-brd wants to merge 1 commit into
brightdata:mainfrom
nirsha-brd:remove-discover-api

Conversation

@nirsha-brd

@nirsha-brd nirsha-brd commented Aug 12, 2026

Copy link
Copy Markdown

Removes brightdata discover / bdata discover and its integration with the Bright Data Discover API (POST/GET https://api.brightdata.com/discover). This is the inverse of #3, which added the command. ## Changes | File | Change | |---|---| | src/commands/discover.ts | deleted | | src/types/discover.ts | deleted — verified nothing outside the discover command imported it | | src/__tests__/commands/discover.test.ts | deleted | | src/index.ts | dropped the import and the program.addCommand(discover_command) registration | | src/__tests__/utils/help.test.ts | dropped the discover case from the "every customer-facing command has Examples in --help" coverage table | | README.md | removed the command-table row, the table-of-contents entry, and the ### discover reference section | src/__tests__/utils/help.test.ts is worth a look in review — it was added after #3, so it is not in that PR's file list, but it imports discover_command and would fail to compile without this change. ## Verification - pnpm run type-check — clean, exit 0 - pnpm run build (tsc) — clean, exit 0 - pnpm testno new failures. This suite is already red on main in a Windows environment; I captured a baseline before making any change and the failing set is byte-for-byte identical: | | Test files | Tests | Failing files | Failing tests | |---|---|---|---|---| | baseline (main) | 29 | 360 | 5 | 8 | | this branch | 28 | 344 | 5 | 8 | The deltas are exactly the removed discover.test.ts (1 file, 16 tests). The same 8 tests fail before and after, all in browser/ipc, browser/lifecycle, commands/browser, utils/config and utils/mcp-config — socket, daemon-spawn and POSIX file-permission assertions that do not hold on Windows. None are related to this change. - node dist/index.js --helpdiscover is gone; all 15 remaining commands still register. - Repo-wide search for discover (excluding node_modules) returns zero matches. ## Migration Use brightdata search to find sources and brightdata scrape to read them. ## Note for reviewers Rebased 2026-08-30 onto current main (0.3.5). The version bump was dropped from this PR: since this removes a public command, the release that ships it should carry the version signal, and that call belongs to the release process. ## Out of scope brightdata/skills still ships a discover-api skill whose CLI section documents bdata discover, and its live-research and rag-pipeline skills are built on Discover. Those need a follow-up PR.

Removes `brightdata discover` / `bdata discover` and its integration with
the Bright Data Discover API (POST/GET https://api.brightdata.com/discover).

Deletes the command, its types and its test file, deregisters it from the
program in src/index.ts, drops the `discover` case from the --help Examples
coverage test, and removes the command from the README command table, table
of contents and reference section.

BREAKING CHANGE: the `discover` command is no longer available.
@nirsha-brd
nirsha-brd force-pushed the remove-discover-api branch from 64a18ea to ad8a9f7 Compare August 30, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant