Delete the Makefile - #191
Merged
Merged
Conversation
Its remaining use was the firebase target for manually deploying Firebase Hosting -- now automated as part of the main Cloud Build trigger (ExtractStatic/FirebaseDeploy steps in cloudbuild.yaml, see #189), making the manual deploy path (and the docker/run/uvicorn/deploy/ test targets alongside it, all superseded by docker compose) dead weight. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hf6j2xXQXywHVh3HAVRxB3
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Its last remaining use was the `firebase` target for manually deploying Firebase Hosting -- now automated by the main Cloud Build trigger's `ExtractStatic`/`FirebaseDeploy` steps (#189), which just proved out successfully in production. The other targets (`docker`/`run`/`uvicorn`/`deploy`/`test`) are all superseded by `docker compose`, which is what this whole session's local dev/testing has used throughout.
Supersedes #187 (which added the `collectstatic`/`firebase` Makefile targets this removes before they ever merged) -- closing that PR as part of this.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
https://claude.ai/code/session_01Hf6j2xXQXywHVh3HAVRxB3