Match Slavic -ovich/-ovitch surname spelling variants in saint search - #177
Merged
Conversation
Older English convention sometimes rendered the "-ovich" patronymic ending as "-ovitch" (e.g. "Maximovitch" vs "Maximovich"); add that as a transliteration.normalize_transliteration rule alongside the existing Greek ones, so search matches across it too. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hf6j2xXQXywHVh3HAVRxB3
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #175/#176. A search for "John Maximovitch" returned nothing, even though that's an exact substring of an existing saint's name in our data ("St John Maximovitch, Metropolitan of Tobolsk") -- turned out to be two compounding issues:
Added a
vitch->vichrule tonormalize_transliteration, alongside the existing Greek rules -- older English convention sometimes rendered the Slavic "-ovich" patronymic ending as "-ovitch". Confirmed via a corpus survey that this is a narrow, low-risk addition: only this one name pair uses either spelling currently.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01Hf6j2xXQXywHVh3HAVRxB3