Repository navigation
fix(pg): mark client not queryable on FATAL or PANIC error messages - #3830
Open
princejain756 wants to merge 1 commit into
Open
princejain756 wants to merge 1 commit into
princejain756 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3826
When a PostgreSQL backend sends an
ErrorResponsewithseverityset to'FATAL'or'PANIC'while an active query is running, the server closes the session immediately without sendingReadyForQuery. Previously,_handleErrorWhileQueryingrouted the error toactiveQuery.handleErrorwithout updatingthis._queryable, leavingclient._queryable === truebetween the error callback firing and the TCP socket closing.Any query issued inside the
FATALerror callback was written onto a connection the server had already terminated, or allowed a pooled client to look reusable beforeendarrived.This sets
this._queryable = falsein_handleErrorWhileQueryingwhenmsg.severity === 'FATAL' || msg.severity === 'PANIC', while leaving normal'ERROR'responses untouched.