Repository navigation
fix(pg): reject queries exceeding parameter limit - #3829
Open
ritiksahni wants to merge 1 commit into
Open
ritiksahni wants to merge 1 commit into
ritiksahni wants to merge 1 commit into
Conversation
Reject more than 65535 parameters before writing protocol messages. Preserve the maximum valid count and add coverage for client, pipeline, cursor, and serializer paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL supports at most 65,535 parameters in a query. pg currently accepts more than that, causing the parameter count to wrap around to a smaller number before it is sent. PostgreSQL then receives a malformed request and returns a confusing error.
This change rejects oversized queries before sending anything to PostgreSQL. The connection remains usable, and other queries in a pipeline continue normally. The valid maximum of 65,535 parameters is still supported.
The fix covers regular queries, cursors, query streams, and the low-level protocol serializer. Tests verify both sides of the limit and connection reuse against PostgreSQL 18.
Native mode already gets the same validation from libpq and does not need to change.
Fixes #2579.